Revert "[Search] Support flexible results-per-row in AllApps"
Revert "[Search] Support flexible results-per-row in AllApps"
Revert submission 13786530-grid_adapter
Bug: 182236647
Reason for revert: b/182236647 [TP1A][SP1A] Launcher crashing on opening Quick search bar from home screen
Reverted Changes:
I36882e12b:[Search] Support flexible results-per-row in AllAp...
Idc3d24daf:[Search] Support flexible results-per-row in AllAp...
Change-Id: Ief3888e63f4946fec43217ce66a1f0a3fb5ff64f
(cherry picked from commit 0cf925dc542309e21c2407a9ad47975302944a1d)
diff --git a/src/com/android/launcher3/allapps/AllAppsGridAdapter.java b/src/com/android/launcher3/allapps/AllAppsGridAdapter.java
index a05e036..5030c5e 100644
--- a/src/com/android/launcher3/allapps/AllAppsGridAdapter.java
+++ b/src/com/android/launcher3/allapps/AllAppsGridAdapter.java
@@ -240,18 +240,20 @@
@Override
public int getSpanSize(int position) {
int viewType = mApps.getAdapterItems().get(position).viewType;
- int totalSpans = mGridLayoutMgr.getSpanCount();
if (isIconViewType(viewType)) {
- return totalSpans / mAppsPerRow;
+ return 1 * SPAN_MULTIPLIER;
} else if (mSearchAdapterProvider.isSearchView(viewType)) {
- return totalSpans / mSearchAdapterProvider.getItemsPerRow(viewType, mAppsPerRow);
+ return mSearchAdapterProvider.getGridSpanSize(viewType, mAppsPerRow);
} else {
// Section breaks span the full width
- return totalSpans;
+ return mAppsPerRow * SPAN_MULTIPLIER;
}
}
}
+ // multiplier to support adapter item column count that is not mAppsPerRow.
+ public static final int SPAN_MULTIPLIER = 3;
+
private final BaseDraggingActivity mLauncher;
private final LayoutInflater mLayoutInflater;
private final AlphabeticalAppsList mApps;
@@ -283,17 +285,14 @@
mOnIconClickListener = launcher.getItemOnClickListener();
- mSearchAdapterProvider = searchAdapterProvider;
setAppsPerRow(mLauncher.getDeviceProfile().inv.numAllAppsColumns);
+
+ mSearchAdapterProvider = searchAdapterProvider;
}
public void setAppsPerRow(int appsPerRow) {
mAppsPerRow = appsPerRow;
- int totalSpans = mAppsPerRow;
- for (int itemPerRow : mSearchAdapterProvider.getSupportedItemsPerRow()) {
- totalSpans *= itemPerRow;
- }
- mGridLayoutMgr.setSpanCount(totalSpans);
+ mGridLayoutMgr.setSpanCount(mAppsPerRow * SPAN_MULTIPLIER);
}
/**
diff --git a/src/com/android/launcher3/allapps/search/SearchAdapterProvider.java b/src/com/android/launcher3/allapps/search/SearchAdapterProvider.java
index 6d491fd..a79ec43 100644
--- a/src/com/android/launcher3/allapps/search/SearchAdapterProvider.java
+++ b/src/com/android/launcher3/allapps/search/SearchAdapterProvider.java
@@ -51,17 +51,10 @@
ViewGroup parent, int viewType);
/**
- * Returns supported item per row combinations supported
- */
- public int[] getSupportedItemsPerRow() {
- return new int[]{};
- }
-
- /**
* Returns how many cells a view should span
*/
- public int getItemsPerRow(int viewType, int appsPerRow) {
- return appsPerRow;
+ public int getGridSpanSize(int viewType, int appsPerRow) {
+ return appsPerRow * AllAppsGridAdapter.SPAN_MULTIPLIER;
}
/**