commit 3da80bd3a15e6ca4a152ccc8f91c99f68f8a8380
author TreeHugger Robot <treehugger-gerrit@google.com> Tue Jan 19 20:26:21 2021 +0000
committer Android (Google) Code Review <android-gerrit@google.com> Tue Jan 19 20:26:21 2021 +0000
tree bd8b90d35e27aa5b6087d4b1fc36ca3cc3cb1d52
parent 6638b566670426ba647b155c0f3df06a21d1b1e0
parent 81aaa265f4c315c31bd93f895a13910d3dd00011

Merge "Resolving a leak of activity via SharedPreferencesImpl.MemoryCommitResult"

src/com/android/launcher3/states/RotationHelper.java

diff --git a/src/com/android/launcher3/states/RotationHelper.java b/src/com/android/launcher3/states/RotationHelper.java
index ecf4f36..ba28e82 100644
--- a/src/com/android/launcher3/states/RotationHelper.java
+++ b/src/com/android/launcher3/states/RotationHelper.java
@@ -51,7 +51,7 @@
     public static final int REQUEST_ROTATE = 1;
     public static final int REQUEST_LOCK = 2;
 
-    private final Activity mActivity;
+    private Activity mActivity;
     private final SharedPreferences mSharedPrefs;
 
     private boolean mIgnoreAutoRotateSettings;
@@ -95,6 +95,7 @@
 
     @Override
     public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, String s) {
+        if (mDestroyed) return;
         boolean wasRotationEnabled = mHomeRotationEnabled;
         mHomeRotationEnabled = mSharedPrefs.getBoolean(ALLOW_ROTATION_PREFERENCE_KEY,
                 getAllowRotationDefaultValue());
@@ -141,6 +142,7 @@
     public void destroy() {
         if (!mDestroyed) {
             mDestroyed = true;
+            mActivity = null;
             if (mSharedPrefs != null) {
                 mSharedPrefs.unregisterOnSharedPreferenceChangeListener(this);
             }